Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tripy] Do not implicitly convert external input formats in convert_inputs_to_tensors decorator #185

Merged
merged 24 commits into from
Sep 16, 2024
Merged

[Tripy] Do not implicitly convert external input formats in convert_inputs_to_tensors decorator #185

merged 24 commits into from
Sep 16, 2024

Conversation

slyubomirsky
Copy link
Collaborator

Addresses issue #168 and does not permit implicit conversion of non-Tripy inputs other than Python numbers (e.g., Numpy arrays).

@slyubomirsky slyubomirsky force-pushed the convert-inputs-accept-only-python-numbers branch from b586ca4 to e0f222d Compare September 5, 2024 21:30
@slyubomirsky slyubomirsky added the tripy Pull request for the tripy project label Sep 5, 2024
@slyubomirsky slyubomirsky changed the title Do not implicitly convert external inputs in convert_inputs_to_tensors decorator [Tripy] Do not implicitly convert external inputs in convert_inputs_to_tensors decorator Sep 5, 2024
@slyubomirsky slyubomirsky changed the title [Tripy] Do not implicitly convert external inputs in convert_inputs_to_tensors decorator [Tripy] Do not implicitly convert external input formats in convert_inputs_to_tensors decorator Sep 5, 2024
@pranavm-nvidia pranavm-nvidia mentioned this pull request Sep 9, 2024
Merged
@slyubomirsky
Copy link
Collaborator Author

Note that the regexes in test_function_registry.py were passing spuriously. I think having lines like | were resulting in matching individual whitespace, so those needed to be escaped.

@slyubomirsky slyubomirsky force-pushed the convert-inputs-accept-only-python-numbers branch from b5f78de to 9b1df32 Compare September 11, 2024 03:28
slyubomirsky
slyubomirsky commented Sep 11, 2024
View reviewed changes
tripy/tripy/types.py Outdated Show resolved Hide resolved
@slyubomirsky slyubomirsky merged commit 8dd8038 into NVIDIA:main Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavm-nvidia pranavm-nvidia pranavm-nvidia approved these changes

Assignees
No one assigned
Labels
tripy Pull request for the tripy project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slyubomirsky @pranavm-nvidia